User talk:Ender R. Musk/Template:SSBU Classic Mode

From SmashWiki, the Super Smash Bros. wiki
< User talk:Ender R. Musk
Revision as of 15:53, July 8, 2021 by CanvasK (talk | contribs) (Created page with "==Minor code changes== #<code><nowiki>{{!}}</nowiki></code> is only needed inside of functions like #if. They can be replaced with normal pipes. #A lot of #ifeq can be simplif...")
(diff) ← Older revision | Latest revision (diff) | Newer revision → (diff)
Jump to navigationJump to search

Minor code changes

  1. {{!}} is only needed inside of functions like #if. They can be replaced with normal pipes.
  2. A lot of #ifeq can be simplified. Example: {{#ifeq:{{{notes|}}}|true|!!Notes}} can be reduced to {{#if:{{{notes|}}}|!!Notes}}. This way as long as "notes" is any value it will work; not much need to be strict about the input in my opinion.
  3. {{#if:{{{round1notes|}}}|{{{round1notes}}}}} can be reduced to just {{{round1notes|}}}; unless you intended it to be {{#if:{{{notes|}}}|{{{round1notes}}}}} to hide all notes if "notes" isn't set. I assume you want the latter because currently without any notes then you have an empty column.
    • Additionally, it should be possible to use mw:Extension:Variables for notes. For instance, doing {{#vardefine:notes|{{#if:{{{round1notes|}}}{{{round2notes|}}}etc...|y}}}} then "notes" can be removed altogether and {{#if:{{{notes|}}}... can be replaced with {{#if:{{#var:notes|}}...

I have an edit put together with the above suggestions if you want them. --CanvasK (talk) 15:53, July 8, 2021 (EDT)