User talk:Ender R. Musk/Template:SSBU Classic Mode

Minor code changes

1. {{!}} is only needed inside of functions like #if. They can be replaced with normal pipes.
2. A lot of #ifeq can be simplified. Example: {{#ifeq:{{{notes|}}}|true|!!Notes}} can be reduced to {{#if:{{{notes|}}}|!!Notes}}. This way as long as "notes" is any value it will work; not much need to be strict about the input in my opinion.
3. {{#if:{{{round1notes|}}}|{{{round1notes}}}}} can be reduced to just {{{round1notes|}}}; unless you intended it to be {{#if:{{{notes|}}}|{{{round1notes}}}}} to hide all notes if "notes" isn't set. I assume you want the latter because currently without any notes then you have an empty column.
   • Additionally, it should be possible to use mw:Extension:Variables for notes. For instance, doing {{#vardefine:notes|{{#if:{{{round1notes|}}}{{{round2notes|}}}etc...|y}}}} then "notes" can be removed altogether and {{#if:{{{notes|}}}... can be replaced with {{#if:{{#var:notes|}}...

I have an edit put together with the above suggestions if you want them. --CanvasK (talk) 15:53, July 8, 2021 (EDT)

1. Thanks!
2. Went with the variable method, thanks!
3. Sometimes, a "notes" cell will be left blank, but others will have content; if I don't have that #if function there, then in that scenario it simply displays the name of the parameter, which is not what we want.

You are free to help without suggesting stuff on this page first! Sincerely, Samuel the Banjo-Kazooie Boss. 16:28, July 8, 2021 (EDT)

For #3 you want to put the final double pipes in the #if ({{!}}{{!}} in this case), otherwise you have a column of empty cells if there are no notes. You can also replace {{#ifeq:{{{#var:notes|}}}|y|5|4}} with {{#if:{{{#var:notes|}}}|5|4}} because "notes" will always either be "y" or nothing, making a check for the only possible option pointless. —Preceding unsigned comment added by CanvasK (talk • contribs) 16:42, July 8, 2021

Once again, can't thank you enough! Sincerely, Samuel the Banjo-Kazooie Boss. 17:22, July 8, 2021 (EDT) P.S. Please remember to sign your talk page posts with ~~~~! (joking)