MediaWiki talk:Common.js: Difference between revisions

Add topic
Active discussions
m (striking out my comment)
m (Text replacement - "w:c:wow:User:Sky2042" to "User:Sky2042")
 
(5 intermediate revisions by 4 users not shown)
Line 15: Line 15:


:<s>There are two copies of the countdown timer code in Common.js, the one near the bottom of the page that is overwriting the functions of the one near the top, can one of them be removed? [[User:LoganA|Logan]] 18:24, 3 March 2008 (UTC)</s>
:<s>There are two copies of the countdown timer code in Common.js, the one near the bottom of the page that is overwriting the functions of the one near the top, can one of them be removed? [[User:LoganA|Logan]] 18:24, 3 March 2008 (UTC)</s>
::It should be fixed now; I had no idea I had put the timer in there before. I also didn't know Splarka had 0.0.3 done; I've put it in now.--[[User:Richard1990|Richard]] 18:32, 3 March 2008 (UTC)
== ajaxRC fix ==
the second h1 tag no longer exist in the monaco skin, can an admin replace the following lines from the code
<pre>
if (skin == "monaco") {
s = 1;
} else {
s = 0;
}
</pre>
with this
<pre>
if (skin == "monaco") {
s = 0;
// was 1, the monaco skin used to have the RC title
// as the 2nd h1 tag the in the DOM tree, but not anymore
} else {
s = 0;
}
</pre> [[User:LoganA|Logan]]&nbsp;'''&middot;'''&nbsp;<small>([[User talk:LoganA|Talk]]&nbsp;'''&middot;'''&nbsp;[[Special:Contributions/LoganA|Contributions]])</small> 04:12, 10 June 2008 (UTC)
:How fixy is it, and have you tested it in monobook? --[[User:Sky2042|Sky]] ([[User talk:Sky2042|t]] · [[Special:Contributions/Sky2042|c]] · [[User:Sky2042|w]]) 04:34, 10 June 2008 (UTC)
:Eep, never mind, totally didn't realize skin had to be monaco. hah. Done. --[[User:Sky2042|Sky]] ([[User talk:Sky2042|t]] · [[Special:Contributions/Sky2042|c]] · [[User:Sky2042|w]]) 04:36, 10 June 2008 (UTC)

Latest revision as of 16:18, March 5, 2023

Countdown fix?Edit

try replacing

var then = timers[i].eventdate;

with

var then = Date.parse(timers[i].eventdate);

Logan 05:13, 3 March 2008 (UTC)

Tried it, doesn't work for me. --Charitwo 05:22, 3 March 2008 (UTC)

also replace this line:

var diff = count=Math.floor((then.getTime()-now.getTime())/1000);

with

var diff = count=Math.floor((then-now.getTime())/1000);

Logan 07:06, 3 March 2008 (UTC)

There are two copies of the countdown timer code in Common.js, the one near the bottom of the page that is overwriting the functions of the one near the top, can one of them be removed? Logan 18:24, 3 March 2008 (UTC)
It should be fixed now; I had no idea I had put the timer in there before. I also didn't know Splarka had 0.0.3 done; I've put it in now.--Richard 18:32, 3 March 2008 (UTC)

ajaxRC fixEdit

the second h1 tag no longer exist in the monaco skin, can an admin replace the following lines from the code

if (skin == "monaco") {
s = 1;
} else {
s = 0;
}

with this

if (skin == "monaco") {
s = 0; 
// was 1, the monaco skin used to have the RC title
// as the 2nd h1 tag the in the DOM tree, but not anymore
} else {
s = 0;
}

Logan · (Talk · Contributions) 04:12, 10 June 2008 (UTC)

How fixy is it, and have you tested it in monobook? --Sky (t · c · w) 04:34, 10 June 2008 (UTC)
Eep, never mind, totally didn't realize skin had to be monaco. hah. Done. --Sky (t · c · w) 04:36, 10 June 2008 (UTC)